[남숙희] Week5#194
Open
sooki88 wants to merge 14 commits intocodeit-bootcamp-frontend:part1-남숙희from
Hidden character warning
The head ref may contain hidden characters: "part1-\ub0a8\uc219\ud76c-week5"
Open
Conversation
| email : userEmail.value, | ||
| password : userPw.value, | ||
| }; | ||
| const p = new Promise(( resolve, reject ) => { |
Collaborator
There was a problem hiding this comment.
여기서는 굳이 Promise패턴을 적용하기보다는 async/await 이 맞는것 같네요. 그리고 Promise 사용법을 잘못알고 있는 것 같습니다. resolve, reject를 어느시점에 하셔야되는 지와 내부에 어떤 Argment를 적어줘야하는지에 대해서 다시 한번 확인해보세요.
Collaborator
Author
There was a problem hiding this comment.
아직 비동기 문법 공부가 많이 부족한 것 같습니다ㅜ 좀 더 공부하겠습니다!
| email : userEmail.value, | ||
| password : userPw.value, | ||
| }; | ||
| const p = new Promise(( resolve, reject ) => { |
Collaborator
There was a problem hiding this comment.
resolve 된 값을 p 변수에 담아서 쓰고 있는데 정작 p 변수를 활용하는 부분은 안보이네요.
차라리 accessApi api 콜을 위한 코드를 async/await 패턴으로 푸는게 더 나아 보입니다.
| @@ -0,0 +1,23 @@ | |||
| export const EMAIL_REGEX = /^[\w-\.]+@([\w-]+\.)+[\w-]{2,4}$/; | |||
Collaborator
There was a problem hiding this comment.
EMAIL_REGEX, PW_REGEX, testUser, codeitApi 같은 경우 utils/const.js 로 빼주세요.
그리고 나머지 함수들은 utils/func.js 로 관리해주시면 되겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게